Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(native filter): undefined layout type on filterInScope #30164

Merged
merged 1 commit into from
Sep 5, 2024
Merged

fix(native filter): undefined layout type on filterInScope #30164

merged 1 commit into from
Sep 5, 2024

Conversation

justinpark
Copy link
Member

SUMMARY

The dashboard layout metadata item has become corrupted, resulting in some values remaining in the filter layout parent ID items that are not included in the dashboard layout. This commit resolves such undefined errors.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
Screenshot 2024-09-05 at 9 59 35 AM
Screenshot 2024-09-05 at 9 54 58 AM

After:
No error shown

TESTING INSTRUCTIONS

locally

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the dashboard:native-filters Related to the native filters of the Dashboard label Sep 5, 2024
@michael-s-molina michael-s-molina added the review:checkpoint Last PR reviewed during the daily review standup label Sep 5, 2024
@justinpark justinpark merged commit e02b18c into apache:master Sep 5, 2024
37 of 38 checks passed
@michael-s-molina michael-s-molina added v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch labels Sep 5, 2024
michael-s-molina pushed a commit that referenced this pull request Sep 5, 2024
@justinpark @michael-s-molina
fix(native filter): undefined layout type on filterInScope (#30164)
87efb72 
(cherry picked from commit e02b18c)
@michael-s-molina michael-s-molina removed the review:checkpoint Last PR reviewed during the daily review standup label Sep 6, 2024
sadpandajoe pushed a commit that referenced this pull request Sep 6, 2024
@justinpark @sadpandajoe
fix(native filter): undefined layout type on filterInScope (#30164)
e946678 
(cherry picked from commit e02b18c)
@github-actions github-actions bot added 🍒 4.1.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:native-filters Related to the native filters of the Dashboard size/XS v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch 🍒 4.1.0 🍒 4.1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinpark @michael-s-molina @mistercrunch