chore(GAQ): Remove GLOBAL_ASYNC_QUERIES_REDIS_CONFIG

[nsivarajan]

SUMMARY

This PR follows up on #29912 and removes the deprecated GLOBAL_ASYNC_QUERIES_REDIS_CONFIG configuration in favor of the new GLOBAL_ASYNC_QUERIES_CACHE_BACKEND configuration. It is intended to be merged into version 5.0.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.46%. Comparing base (dfb9af3) to head (df76251).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
superset/async_events/async_query_manager.py	75.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #30284       +/-   ##
===========================================
+ Coverage        0   83.46%   +83.46%     
===========================================
  Files           0      546      +546     
  Lines           0    39284    +39284     
===========================================
+ Hits            0    32787    +32787     
- Misses          0     6497     +6497     

Flag	Coverage Δ
hive	48.81% <75.00%> (?)
mysql	75.99% <75.00%> (?)
postgres	76.05% <75.00%> (?)
presto	53.30% <75.00%> (?)
python	83.46% <75.00%> (?)
sqlite	75.52% <75.00%> (?)
unit	61.08% <75.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rusackas]

I think @villebro has the most context here, so I'll request his review, and re-start our flaky E2E test while I'm at it.

[villebro]

@nsivarajan can you rebase this PR? The breaking change window for 5.0 is open, so we can now merge this.

[nsivarajan]

@villebro Sure - I'll update in two days

[nsivarajan]

Hi @villebro,
I've pushed the recent commits to the PR. Could you please assist with the review when you have time?

[villebro]

Looks good! One redundant comment found + we need to add a comment to UPDATING.md to alert about the breaking change. Under the "Next" heading you should add a note pointing to this PR that states that the old config flag has been removed in favor of the new one, preferably explaining how to change the old config to the new one. After that we can merge this.

[villebro]

@nsivarajan UPDATING.md entry looks good, but it seems the rebase was unsuccessful, as there's been some unrelated changes. Can you fix the conflict and make sure only your change is present in the diff?

[villebro]

LGTM, thanks for the quick updates!

[nsivarajan]

Thanks, @villebro, for all the guidance. As always, it's been very helpful!

[villebro]

Thanks, @villebro, for all the guidance. As always, it's been very helpful!

@nsivarajan it was my pleasure, thanks for taking care of this important breaking change for 5.0! I'm rerunning some flaky CI tests, will merge once CI is green.

[michael-s-molina]

The E2E failure is unrelated to this PR and will be fixed by #31933.

[villebro]

Close/reopen to restart CI after fixed flaky test.

[villebro]

@nsivarajan can you rebase the PR to see if the flaky test now passes? Closing/reopening didn't resolve the issue.

[nsivarajan]

@villebro - Thanks again, finally all green! please help to merge.

[villebro]

Finally!