fix: KeyError 'sql' when opening a Trino virtual dataset #30339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
global:jinja
| @@ -90,7 +90,6 @@ def execute( | |||
| rendered_query: str, | |||
| log_params: dict[str, Any] | None, | |||
| ) -> SqlJsonExecutionStatus: | |||
| print(">>> execute <<<") | |||
There was a problem hiding this comment.
Leftovers from the original PR.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #30339 +/- ##
===========================================
+ Coverage 60.48% 83.89% +23.41%
===========================================
Files 1931 533 -1398
Lines 76236 38489 -37747
Branches 8568 0 -8568
===========================================
- Hits 46114 32292 -13822
+ Misses 28017 6197 -21820
+ Partials 2105 0 -2105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
michael-s-molina
force-pushed
the
fix-sql-key-error
branch
from
1ebd222 to
2bded1e
Compare
michael-s-molina
added
the
v4.1
villebro
approved these changes
Sep 19, 2024
sadpandajoe
pushed a commit
that referenced
this pull request
Sep 19, 2024
(cherry picked from commit ef9e5e5)
github-actions
bot
added
🍒 4.1.0
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
#27470 modified the logic to validate a SQL Lab query by checking the access permission before any Jinja rendering occurs as some Jinja macros execute statements upon rendering. Those changes left an unused shallow copy statement that was interfering with SQL Alchemy internal state provoking key errors. This PR removes the unused statements.
Fixes #30338
TESTING INSTRUCTIONS
Follow the instructions described in the original issue.
ADDITIONAL INFORMATION