fix: update html rendering to true from false #30565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/testenv up |
|
@sadpandajoe Ephemeral environment spinning up at http://34.222.140.49:8080. Credentials are |
|
/testenv up |
|
@sadpandajoe Ephemeral environment spinning up at http://54.201.170.229:8080. Credentials are |
|
@sadpandajoe Ephemeral environment spinning up at http://54.185.164.57:8080. Credentials are |
eschutho
approved these changes
Oct 9, 2024
michael-s-molina
approved these changes
Oct 10, 2024
michael-s-molina
added
the
v4.1
|
Ephemeral environment shutdown and build artifacts deleted. |
sadpandajoe
added a commit
that referenced
this pull request
Oct 10, 2024
mistercrunch
pushed a commit
that referenced
this pull request
Oct 28, 2024
github-actions
bot
added
🍒 4.1.0
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In Superset 4.0, we used to render html in SQL Lab, but with #27969, we added the option to not render html at all. However, as part of the PR, it is defaulting to
falsevs defaulting totruewhich is the existing behavior users are expecting.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION