Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use dialect when tokenizing #30614

Merged
merged 2 commits into from
Oct 15, 2024
Merged

feat: use dialect when tokenizing #30614

merged 2 commits into from
Oct 15, 2024

Conversation

betodealmeida
Copy link
Member

SUMMARY

A small improvement to #30578, using the dialect to do the tokenization. Note that a dialect might be available when ast.sql() raises an exception.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@betodealmeida betodealmeida merged commit 4cac7fe into master Oct 15, 2024
33 checks passed
@sadpandajoe sadpandajoe added v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch and removed v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch labels Oct 15, 2024
sadpandajoe pushed a commit that referenced this pull request Oct 15, 2024
@betodealmeida @sadpandajoe
feat: use dialect when tokenizing (#30614)
046770c 
(cherry picked from commit 4cac7fe)
@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Oct 15, 2024
mistercrunch pushed a commit that referenced this pull request Oct 28, 2024
@betodealmeida @mistercrunch
feat: use dialect when tokenizing (#30614)
390fa30
@github-actions github-actions bot added 🍒 4.1.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eschutho eschutho eschutho approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch 🍒 4.1.0 🍒 4.1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@betodealmeida @eschutho @mistercrunch @sadpandajoe