Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): bump css-loader from 6.8.1 to 7.1.2 in /superset-frontend #31661

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 1, 2025

Bumps css-loader from 6.8.1 to 7.1.2.

Release notes

Sourced from css-loader's releases.

v7.1.2

7.1.2 (2024-05-22)

Bug Fixes

  • keep order of @imports with the webpackIgnore comment (#1600) (76757ef)

v7.1.1

7.1.1 (2024-04-10)

Bug Fixes

  • automatically rename class default to _default when named export is enabled (#1590) (d6c31a1)

v7.1.0

7.1.0 (2024-04-08)

Features

  • added the getJSON option to output CSS modules mapping (#1577) (af834b4)

v7.0.0

7.0.0 (2024-04-04)

⚠ BREAKING CHANGES

  • The modules.namedExport option is true by default if you enable the esModule option

Migration guide:

Before:

import style from "./style.css";
console.log(style.myClass);

After:

import * as style from "./style.css";
console.log(style.myClass);

... (truncated)

Changelog

Sourced from css-loader's changelog.

7.1.2 (2024-05-22)

Bug Fixes

  • keep order of @imports with the webpackIgnore comment (#1600) (76757ef)

7.1.1 (2024-04-10)

Bug Fixes

  • automatically rename class default to _default when named export is enabled (#1590) (d6c31a1)

7.1.0 (2024-04-08)

Features

  • added the getJSON option to output CSS modules mapping (#1577) (af834b4)

7.0.0 (2024-04-04)

⚠ BREAKING CHANGES

  • The modules.namedExport option is true by default if you enable the esModule option

Migration guide:

Before:

import style from "./style.css";
console.log(style.myClass);

After:

import * as style from "./style.css";
console.log(style.myClass);

To restore 6.x behavior, please use:

module.exports = {
</tr></table> 

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Description by Korbit AI

What change is being made?

Bump the css-loader dependency from version 6.8.1 to 7.1.2 in the superset-frontend.

Why are these changes being made?

This change updates the css-loader to the latest stable version to ensure compatibility with other dependencies and to benefit from the latest features and bug fixes. It also addresses any potential security vulnerabilities or deprecations in the previous version.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

@dependabot dependabot bot added dependabot npm Dependabot - npm related PRs labels Jan 1, 2025
Copy link

korbit-ai bot commented Jan 1, 2025

By default, I don't review pull requests opened by bots. If you would like me to review this pull request anyway, you can request a review via the /korbit-review command in a comment.

@sadpandajoe
Copy link
Member

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/superset-frontend/css-loader-7.1.2 branch from 1ebd2b5 to bcca8ad Compare January 6, 2025 23:20
@sadpandajoe sadpandajoe added the risk:breaking-change Issues or PRs that will introduce breaking changes label Jan 6, 2025
@rusackas
Copy link
Member

rusackas commented Jan 7, 2025

I don't think there are any real breaking changes here, are there? That said, I think now (with the breaking change window open) is the logical time to merge this. CC @michael-s-molina in case you feel differently :D

@michael-s-molina
Copy link
Member

michael-s-molina commented Jan 7, 2025

According to the Changelog in the PR description, the breaking change is this:

The modules.namedExport option is true by default if you enable the esModule option

@sadpandajoe Will this have any impact for us?

@sadpandajoe
Copy link
Member

According to the Changelog in the PR description, the breaking change is this:

The modules.namedExport option is true by default if you enable the esModule option

@sadpandajoe Will this have any impact for us?

@michael-s-molina I did a quick search for esModule and noticed that we already set it to true. But might be looking in the wrong spot.

Bumps [css-loader](https://github.com/webpack-contrib/css-loader) from 6.8.1 to 7.1.2.
- [Release notes](https://github.com/webpack-contrib/css-loader/releases)
- [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md)
- [Commits](webpack-contrib/css-loader@v6.8.1...v7.1.2)

---
updated-dependencies:
- dependency-name: css-loader
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/superset-frontend/css-loader-7.1.2 branch from bcca8ad to 004e5d8 Compare January 9, 2025 20:47
@rusackas
Copy link
Member

rusackas commented Jan 9, 2025

I think we're OK here. Merging, and if it breaks anything, I volunteer to fix it :)

@rusackas rusackas merged commit 5f18e84 into master Jan 9, 2025
53 checks passed
@rusackas rusackas deleted the dependabot/npm_and_yarn/superset-frontend/css-loader-7.1.2 branch January 9, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependabot dependencies:npm npm Dependabot - npm related PRs risk:breaking-change Issues or PRs that will introduce breaking changes size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants