-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(eslint): disabling wildcard imports with eslint #31761
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
Category | Issue | Fix Detected |
---|---|---|
Unsafe Date Parsing ▹ view | ✅ | |
Avoid ignoring ESLint rule 'no-restricted-syntax'. ▹ view | ||
Invalid ESLint Disable Comment ▹ view | ✅ |
Need a new review? Comment
/korbit-review
on this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-review
command in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-description
command in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolve
command in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Feedback and Support
/* eslint-ignore-next-line no-restricted-syntax*/ | ||
import * as d3array from 'd3-array'; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed
@@ -50,7 +50,7 @@ const getJSONSchema = () => { | |||
jsonSchema.properties[key] = { | |||
...value, | |||
default: value.default | |||
? chrono.parseDate(value.default)?.toISOString() | |||
? parseDate(value.default)?.toISOString() |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
superset-frontend/plugins/legacy-preset-chart-deckgl/src/utils/sandbox.ts
Outdated
Show resolved
Hide resolved
@jpchev do you mean to see what the rules are? There are various eslint.config.js files in the codebase you can look at. If you mean you want to run the script to test it, you can check the |
23dfabe
to
0cc8360
Compare
yes thank you, anyway |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
@justinpark adeptly spotted a wildcard input on a PR here. I figured this might be happening elsewhere, so I added a lint rule, and cleaned up the fallout. This should lead to a smaller bundle size, with any luck, or at least better hygiene.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION