Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add unicode data to tests #432

Merged
merged 6 commits into from
May 5, 2016
Merged

add unicode data to tests #432

merged 6 commits into from
May 5, 2016
+140 −6

Conversation

andrewhn
Copy link
Contributor

@andrewhn andrewhn commented May 4, 2016

As promised, this PR:

  • adds a csv with unicode data for testing to caravel/data
  • adds a loading function for the data, activated with command line flag --test (and by the tests)
  • adds a table, slice (pic below), and dashboard featuring unicode data (if --test is specified)

Note I changed the sample flag in the data load command in bin/caravel, as it didn't seem to be doing anything.

Also fixes #395.

image

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.29% when pulling 1a54e4e on andrewhn:unicode_tests into 0bedaed on airbnb:master.

@coveralls
Copy link

coveralls commented May 4, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.5%) to 81.822% when pulling 1a54e4e on andrewhn:unicode_tests into 0bedaed on airbnb:master.

@andrewhn
clean up data loading
42190c1 
- remove duplicate keys in slice_data
- reduce line length
@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 42190c1 on andrewhn:unicode_tests into 0bedaed on airbnb:master.

@coveralls
Copy link

coveralls commented May 5, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.5%) to 81.822% when pulling 42190c1 on andrewhn:unicode_tests into 0bedaed on airbnb:master.

@mistercrunch
Copy link
Member

Awesome! --sample was leftover from earlier logic I had to load samples faster to accelerate the tests.

mistercrunch
mistercrunch reviewed May 5, 2016
View reviewed changes
caravel/bin/caravel
'-s', '--sample', action='store_true',
help="Only load 1000 rows (faster, used for testing)")
def load_examples(sample):
'-s', '--test', action='store_true',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'-t', '--include-test-data', action='store_true',

@mistercrunch
Copy link
Member

Looks perfect except for the few nits that I pointed out. Thanks for doing this!

@andrewhn
Copy link
Contributor Author

andrewhn commented May 5, 2016

No worries, should be all good 👍

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 6dfbcdb on andrewhn:unicode_tests into a3f549b on airbnb:master.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 6dfbcdb on andrewhn:unicode_tests into a3f549b on airbnb:master.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 6dfbcdb on andrewhn:unicode_tests into a3f549b on airbnb:master.

@coveralls
Copy link

coveralls commented May 5, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.5%) to 81.822% when pulling 6dfbcdb on andrewhn:unicode_tests into a3f549b on airbnb:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 81.822% when pulling 6dfbcdb on andrewhn:unicode_tests into a3f549b on airbnb:master.

@mistercrunch mistercrunch merged commit 6941f1d into apache:master May 5, 2016
@mistercrunch
Copy link
Member

img

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
@kristw @zhaoyongjie
feat: migrate xy-chart to use encodable (apache#438)
40cd157 
* feat: migrate xy-chart to use encodable (apache#420)

* feat: use encodable in BoxPlot

* feat: migrate legend

* docs: update storybook

* fix: label overlap

* fix: lint

* fix: remove comments

* fix: path

* feat: migrate scatterplot to use encodable (apache#421)

* feat: migrate scatter plot

(cherry picked from commit 0d607a60cdab8037ece7f29a74bef1c0a5432c5d)

* fix: legend

* feat: migrate line chart to use encodable (apache#427)

* feat: migrate line to use encodable

* fix: storybook ts

* fix: remove comment

* refactor: delete deprecated files (apache#430)

* refactor: delete outdated files

* feat: update index exports and add test

* refactor: delete more files

* fix: import order

* fix: update dependency

* fix: update dependency

* build: fix babel

* fix: remvoe comments

* fix: babel

* refactor: move files (apache#432)

* refactor: move files

* refactor: move files

* fix: small issues with charts post-migration (apache#433)

* fix: scatterplot issue

* fix: bump encodable and fix time scale nicing

* fix: issue with label rotation

* refactor: remove deep import

* fix: demo import

* feat: bump and remove unnecessary dependencies (apache#436)

* feat: bump dependencies

* feat: remove unnecessary dependencies
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
@suddjian @zhaoyongjie
add calendar control panel (apache#432)
a4b7438
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
@kristw @zhaoyongjie
feat: migrate xy-chart to use encodable (apache#438)
4603c9f 
* feat: migrate xy-chart to use encodable (apache#420)

* feat: use encodable in BoxPlot

* feat: migrate legend

* docs: update storybook

* fix: label overlap

* fix: lint

* fix: remove comments

* fix: path

* feat: migrate scatterplot to use encodable (apache#421)

* feat: migrate scatter plot

(cherry picked from commit 0d607a60cdab8037ece7f29a74bef1c0a5432c5d)

* fix: legend

* feat: migrate line chart to use encodable (apache#427)

* feat: migrate line to use encodable

* fix: storybook ts

* fix: remove comment

* refactor: delete deprecated files (apache#430)

* refactor: delete outdated files

* feat: update index exports and add test

* refactor: delete more files

* fix: import order

* fix: update dependency

* fix: update dependency

* build: fix babel

* fix: remvoe comments

* fix: babel

* refactor: move files (apache#432)

* refactor: move files

* refactor: move files

* fix: small issues with charts post-migration (apache#433)

* fix: scatterplot issue

* fix: bump encodable and fix time scale nicing

* fix: issue with label rotation

* refactor: remove deep import

* fix: demo import

* feat: bump and remove unnecessary dependencies (apache#436)

* feat: bump dependencies

* feat: remove unnecessary dependencies
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
@suddjian @zhaoyongjie
add calendar control panel (apache#432)
4331bcf
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
@kristw @zhaoyongjie
feat: migrate xy-chart to use encodable (apache#438)
8ce2b5b 
* feat: migrate xy-chart to use encodable (apache#420)

* feat: use encodable in BoxPlot

* feat: migrate legend

* docs: update storybook

* fix: label overlap

* fix: lint

* fix: remove comments

* fix: path

* feat: migrate scatterplot to use encodable (apache#421)

* feat: migrate scatter plot

(cherry picked from commit 0d607a60cdab8037ece7f29a74bef1c0a5432c5d)

* fix: legend

* feat: migrate line chart to use encodable (apache#427)

* feat: migrate line to use encodable

* fix: storybook ts

* fix: remove comment

* refactor: delete deprecated files (apache#430)

* refactor: delete outdated files

* feat: update index exports and add test

* refactor: delete more files

* fix: import order

* fix: update dependency

* fix: update dependency

* build: fix babel

* fix: remvoe comments

* fix: babel

* refactor: move files (apache#432)

* refactor: move files

* refactor: move files

* fix: small issues with charts post-migration (apache#433)

* fix: scatterplot issue

* fix: bump encodable and fix time scale nicing

* fix: issue with label rotation

* refactor: remove deep import

* fix: demo import

* feat: bump and remove unnecessary dependencies (apache#436)

* feat: bump dependencies

* feat: remove unnecessary dependencies
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
@suddjian @zhaoyongjie
add calendar control panel (apache#432)
795d86d
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@kristw @zhaoyongjie
feat: migrate xy-chart to use encodable (apache#438)
493df5c 
* feat: migrate xy-chart to use encodable (apache#420)

* feat: use encodable in BoxPlot

* feat: migrate legend

* docs: update storybook

* fix: label overlap

* fix: lint

* fix: remove comments

* fix: path

* feat: migrate scatterplot to use encodable (apache#421)

* feat: migrate scatter plot

(cherry picked from commit 0d607a60cdab8037ece7f29a74bef1c0a5432c5d)

* fix: legend

* feat: migrate line chart to use encodable (apache#427)

* feat: migrate line to use encodable

* fix: storybook ts

* fix: remove comment

* refactor: delete deprecated files (apache#430)

* refactor: delete outdated files

* feat: update index exports and add test

* refactor: delete more files

* fix: import order

* fix: update dependency

* fix: update dependency

* build: fix babel

* fix: remvoe comments

* fix: babel

* refactor: move files (apache#432)

* refactor: move files

* refactor: move files

* fix: small issues with charts post-migration (apache#433)

* fix: scatterplot issue

* fix: bump encodable and fix time scale nicing

* fix: issue with label rotation

* refactor: remove deep import

* fix: demo import

* feat: bump and remove unnecessary dependencies (apache#436)

* feat: bump dependencies

* feat: remove unnecessary dependencies
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@suddjian @zhaoyongjie
add calendar control panel (apache#432)
561f309
This was referenced Jan 23, 2023
Open
Open
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.9.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSV export fails
4 participants
@andrewhn @landscape-bot @coveralls @mistercrunch