[druid] fix 'Unorderable types' when col has nulls #4771
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error "unorderable types: str() < int()" occurs when grouping by a
numerical Druid colummn that contains null values.
* druid/pydruid returns strings in the datafram with NAs for nulls
* Superset has custom logic around get_fillna_for_col that fills in the
NULLs based on declared column type (FLOAT here), so now we have a mixed
bag of type in the series
* pandas chokes on pivot_table or groupby operations as it cannot sorts
mixed types
The approach here is to stringify and fillna('<NULL>') to get a
consistent series.
mistercrunch
force-pushed
the
druid_nulls
branch
from
7f06fb7 to
5e4888a
Compare
Codecov Report
@@ Coverage Diff @@
## master #4771 +/- ##
=========================================
+ Coverage 72.59% 72.6% +<.01%
=========================================
Files 205 205
Lines 15401 15406 +5
Branches 1183 1183
=========================================
+ Hits 11180 11185 +5
Misses 4218 4218
Partials 3 3
Continue to review full report at Codecov.
|
mistercrunch
changed the title
|
Merging onto #4651 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error "unorderable types: str() < int()" occurs when grouping by a
numerical Druid colummn that contains null values.
NULLs based on declared column type (FLOAT here), so now we have a mixed
bag of type in the series
mixed types
The approach here is to stringify and fillna('') to get a
consistent series.
Related: #3029