Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing datasource error message #5019

Merged
merged 3 commits into from
May 18, 2018
+6 −0
Merged

fix missing datasource error message #5019

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf374ef
fix missing datasource error message
timifasubaa May 16, 2018
f52f7aa
raise exception early
timifasubaa May 18, 2018
63115fb
nit
timifasubaa May 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions superset/views/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1229,6 +1229,12 @@ def datasource_info(datasource_id, datasource_type, form_data):
datasource = form_data.get('datasource', '')
if '__' in datasource:
datasource_id, datasource_type = datasource.split('__')
# The case where the datasource has been deleted
datasource_id = None if datasource_id == 'None' else datasource_id
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how datasource_id == 'None' comes into being in the first place. Can we catch the issue upstream?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. I was also confused at the beginning. datasource evaluates to 'None__Table', so splitting that gets 'None'. I'll investigate upstream.


if not datasource_id:
raise Exception(
'The data source associated with this chart no longer exists')
datasource_id = int(datasource_id)
return datasource_id, datasource_type

Expand Down