[security] allow security manager provide error message #5500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timifasubaa
force-pushed
the
allow_security_manager_provide_error_message
branch
6 times, most recently
from
e4375f2 to
f87585d
Compare
timifasubaa
force-pushed
the
allow_security_manager_provide_error_message
branch
from
f87585d to
a0c4858
Compare
timifasubaa
changed the title
Codecov Report
@@ Coverage Diff @@
## master #5500 +/- ##
==========================================
- Coverage 63.37% 63.29% -0.08%
==========================================
Files 349 349
Lines 22110 22114 +4
Branches 2455 2455
==========================================
- Hits 14013 13998 -15
- Misses 8083 8102 +19
Partials 14 14
Continue to review full report at Codecov.
|
john-bodley
reviewed
Jul 27, 2018
| @@ -1260,9 +1255,11 @@ def explore(self, datasource_type=None, datasource_id=None): | |||
| flash(DATASOURCE_MISSING_ERR, 'danger') | |||
| return redirect(error_redirect) | |||
|
|
|||
| if not security_manager.datasource_access(datasource): | |||
| if config.get('ENABLE_ACCESS_REQUEST') and ( | |||
There was a problem hiding this comment.
A check is done at a lower point (in explore_json) This check here is strictly for redirecting users who don't have access to the access request page.
timifasubaa
added a commit
to airbnb/superset-fork
that referenced
this pull request
Aug 2, 2018
(cherry picked from commit 3b6cafc)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
@john-bodley @michellethomas @mistercrunch