Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix - pass link not error message #5512

Merged
merged 2 commits into from
Jul 30, 2018
Merged

Conversation

timifasubaa
Copy link
Contributor

Earlier PR passed the error message as a link instead of the link. This PR corrects that and passes the link.

@codecov-io
Copy link

codecov-io commented Jul 30, 2018

Codecov Report

Merging #5512 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5512   +/-   ##
=======================================
  Coverage   63.28%   63.28%           
=======================================
  Files         349      349           
  Lines       22121    22121           
  Branches     2457     2457           
=======================================
  Hits        13999    13999           
  Misses       8108     8108           
  Partials       14       14
Impacted Files Coverage Δ
superset/views/core.py 74.17% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b6cafc...2399d4d. Read the comment docs.

@timifasubaa timifasubaa merged commit 9e67445 into master Jul 30, 2018
timifasubaa added a commit to airbnb/superset-fork that referenced this pull request Aug 2, 2018
* hotfix - pass link not error message

* nit

(cherry picked from commit 9e67445)
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
* hotfix - pass link not error message

* nit
@kristw kristw deleted the hotfix-pass-link-not-errormsg branch March 6, 2019 16:46
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants