Stop pretty printing dashboard json #5538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
approved these changes
Aug 1, 2018
michellethomas
force-pushed
the
no_pretty_print_dashboard_json
branch
from
caebcdd to
77f7917
Compare
john-bodley
pushed a commit
to john-bodley/superset
that referenced
this pull request
Aug 1, 2018
(cherry picked from commit b564aa4)
john-bodley
added a commit
to airbnb/superset-fork
that referenced
this pull request
Aug 1, 2018
Stop pretty printing dashboard json (apache#5538)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to pretty print the dashboard json, and removing this will save space in the db.
Testing
Opened a dashboard that's at the size limit and added more to it, checked that json was not pretty printed and the position_json is under the size limit.
@john-bodley @graceguo-supercat