Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force quoted column aliases for Oracle-like databases #5686

Merged
merged 29 commits into from
Sep 4, 2018
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
d5242d0
Replace dataframe label override logic with table column override
villebro Aug 22, 2018
ead1b55
Add mutation to any_date_col
villebro Aug 22, 2018
4540d11
Linting
villebro Aug 22, 2018
027f794
Add mutation to oracle and redshift
villebro Aug 22, 2018
f8f851a
Fine tune how and which labels are mutated
villebro Aug 23, 2018
ce3617b
Implement alias quoting logic for oracle-like databases
villebro Aug 25, 2018
5f67d59
Fix and align column and metric sqla_col methods
villebro Aug 25, 2018
8b6e52d
Clean up typos and redundant logic
villebro Aug 25, 2018
62163fa
Move new attribute to old location
villebro Aug 25, 2018
e8dd7da
Linting
villebro Aug 25, 2018
6c6436f
Replace old sqla_col property references with function calls
villebro Aug 25, 2018
4b0e593
Remove redundant calls to mutate_column_label
villebro Aug 26, 2018
76959dd
Move duplicated logic to common function
villebro Aug 26, 2018
6c7fccc
Add db_engine_specs to all sqla_col calls
villebro Aug 26, 2018
c187104
Add missing mydb
villebro Aug 26, 2018
53b77a2
Add note about snowflake-sqlalchemy regression
villebro Aug 26, 2018
e792d15
Make db_engine_spec mandatory in sqla_col
villebro Aug 26, 2018
44eac83
Small refactoring and cleanup
villebro Aug 26, 2018
a161efc
Remove db_engine_spec from get_from_clause call
villebro Aug 26, 2018
901b635
Make db_engine_spec mandatory in adhoc_metric_to_sa
villebro Aug 26, 2018
7e7a2a8
Remove redundant mutate_expression_label call
villebro Aug 26, 2018
d60ed34
Add missing db_engine_specs to adhoc_metric_to_sa
villebro Aug 26, 2018
fc2c4f2
Rename arg label_name to label in get_column_label()
villebro Aug 27, 2018
3f2d874
Rename label function and add docstring
villebro Aug 27, 2018
95c99d3
Remove redundant db_engine_spec args
villebro Aug 27, 2018
04d3b5f
Rename col_label to label
villebro Aug 27, 2018
efb6313
Remove get_column_name wrapper and make direct calls to db_engine_spec
villebro Aug 27, 2018
3a6fe4b
Remove unneeded db_engine_specs
villebro Aug 27, 2018
0d18163
Rename sa_ vars to sqla_
villebro Aug 27, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Linting
villebro committed Aug 25, 2018
commit e8dd7da2233b8cece256cca294a8de345c160f8a
2 changes: 1 addition & 1 deletion superset/db_engine_specs.py
Original file line number Diff line number Diff line change
@@ -35,7 +35,7 @@
from sqlalchemy import select
from sqlalchemy.engine import create_engine
from sqlalchemy.engine.url import make_url
from sqlalchemy.sql import text, quoted_name
from sqlalchemy.sql import quoted_name, text
from sqlalchemy.sql.expression import TextAsFrom
import sqlparse
from tableschema import Table