-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SIP-5] Refactor sunburst #5699
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5699 +/- ##
==========================================
- Coverage 63.45% 63.44% -0.01%
==========================================
Files 361 361
Lines 22972 22974 +2
Branches 2557 2557
==========================================
Hits 14576 14576
- Misses 8381 8383 +2
Partials 15 15
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ready to merge |
* extract slice and formData * fix small issues * Update visual * update css (cherry picked from commit 8d01c84)
* extract slice and formData * fix small issues * Update visual * update css (cherry picked from commit 8d01c84)
* extract slice and formData * fix small issues * Update visual * update css
* extract slice and formData * fix small issues * Update visual * update css
slice
andformData
according to [SIP-5]@williaster @conglei