Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable all js unit tests again #5943

Merged
merged 1 commit into from
Sep 20, 2018

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Sep 20, 2018

remove .only from one of unit test.

@mistercrunch @graceguo-supercat @williaster

@codecov-io
Copy link

codecov-io commented Sep 20, 2018

Codecov Report

Merging #5943 into master will increase coverage by 15.38%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #5943       +/-   ##
===========================================
+ Coverage    48.2%   63.58%   +15.38%     
===========================================
  Files         393      393               
  Lines       23588    23588               
  Branches     2630     2630               
===========================================
+ Hits        11371    14999     +3628     
+ Misses      12217     8576     -3641     
- Partials        0       13       +13
Impacted Files Coverage Δ
...erset/assets/src/explore/actions/exploreActions.js 57.33% <0%> (+1.33%) ⬆️
...set/assets/src/dashboard/actions/dashboardState.js 44.27% <0%> (+2.29%) ⬆️
superset/assets/src/visualizations/nvd3/utils.js 24.32% <0%> (+4.5%) ⬆️
superset/assets/src/locales.jsx 27.83% <0%> (+6.18%) ⬆️
...t/assets/src/SqlLab/components/CopyQueryTabUrl.jsx 78.57% <0%> (+7.14%) ⬆️
superset/assets/src/profile/components/App.jsx 100% <0%> (+7.69%) ⬆️
superset/assets/src/visualizations/nvd3/NVD3Vis.js 7.99% <0%> (+7.99%) ⬆️
...rc/dashboard/components/dnd/dragDroppableConfig.js 52% <0%> (+8%) ⬆️
...uperset/assets/src/profile/components/UserInfo.jsx 100% <0%> (+9.09%) ⬆️
superset/assets/src/components/TooltipWrapper.jsx 100% <0%> (+10%) ⬆️
... and 187 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00c4c7e...69fcdce. Read the comment docs.

@mistercrunch
Copy link
Member

Thanks for fixing this quickly!

@mistercrunch mistercrunch merged commit 8c83b72 into apache:master Sep 20, 2018
@williaster
Copy link
Contributor

Preventing this in the future with #5945

@kristw
Copy link
Contributor Author

kristw commented Sep 20, 2018 via email

@kristw kristw deleted the kristw-fix-unit-test branch September 20, 2018 21:51
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants