-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce data loaded before loading tests #6298
Conversation
a6234ed
to
d84db1c
Compare
Codecov Report
@@ Coverage Diff @@
## master #6298 +/- ##
==========================================
- Coverage 77.31% 73.38% -3.94%
==========================================
Files 67 67
Lines 9581 9582 +1
==========================================
- Hits 7408 7032 -376
- Misses 2173 2550 +377
Continue to review full report at Codecov.
|
Ballpark before/after times? |
@mistercrunch Shaved off about ~ 1 minute from the Python tests. From 5-6 mutes to 4 minutes |
Not sure how others feel about removing the loading of these data sets completely. I wonder if we can have a flag for loading all data vs loading basic data sets. That way if some tests want to use all data they can. |
ee1d7b9
to
f52253a
Compare
f52253a
to
db142d6
Compare
@michellethomas Agree. I updated the PR to only remove it completely from the tests loading. |
PING |
@michellethomas |
superset/cli.py
Outdated
if load_test_data: | ||
print('Loading [Unicode test data]') | ||
data.load_unicode_test_data() | ||
if load_test_data: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nested under if not load_test_data:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
db142d6
to
5f5bda9
Compare
lgtm |
* reduce data loaded before loading tests * make cypress only load needed tests
This PR pushes down the CI build times for python tests by reducing the tables loaded before running the tests.
@john-bodley @mistercrunch @michellethomas