-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing sort issue with area chart and adding tests #6358
Fixing sort issue with area chart and adding tests #6358
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6358 +/- ##
==========================================
+ Coverage 56.07% 56.07% +<.01%
==========================================
Files 525 525
Lines 23212 23214 +2
Branches 2776 2776
==========================================
+ Hits 13016 13018 +2
Misses 9787 9787
Partials 409 409
Continue to review full report at Codecov.
|
24f3997
to
2f041b6
Compare
This PR is a bit old but still relevant, so I rebased and will merge it in. I don't think the line |
LGTM |
(cherry picked from commit 8100a8f)
(cherry picked from commit 8100a8f)
(cherry picked from commit 0794cda)
There's an issue where the area (stacked line) chart doesn't sort correctly. At the end of get_data for NVD3 charts the data gets sorted. I asked Beto about this line added here and it looks like it's necessary for time shift coloring. I believe the correct way to handle this is to see if the chart sorts the series (with
self.sort_series
flag), but I'm not sure if I'm missing any edge cases.I've added tests to make sure the area chart is sorted correctly, and make sure the line chart with time shift has the correct colors.
@betodealmeida @john-bodley @graceguo-supercat