Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ASF license from github templates (PR and issues) #7217

Merged
merged 2 commits into from
Apr 9, 2019

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Apr 3, 2019

It shows as people open issues and PRs and it's confusing... Hopefully the build is cool with this...

<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements.  See the NOTICE file
distributed with this work for additional information
regarding copyright ownership.  The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License.  You may obtain a copy of the License at

  http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied.  See the License for the
specific language governing permissions and limitations
under the License.
-->

It shows as people open issues and PRs and it's confusing...
@kristw
Copy link
Contributor

kristw commented Apr 3, 2019

It isn't...

@michellethomas
Copy link
Contributor

Yeah I wasn't sure how to get around this with the PR template, build requires all files to have the apache license header.

@mistercrunch
Copy link
Member Author

Tried nuking the travis cache without success :(
Screen Shot 2019-04-04 at 11 14 37 PM

@mistercrunch
Copy link
Member Author

Ok, tried to delete the PR's cache on travis as well as the master cache, restarted the build...

@codecov-io
Copy link

Codecov Report

Merging #7217 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7217      +/-   ##
==========================================
- Coverage   64.62%   64.62%   -0.01%     
==========================================
  Files         422      422              
  Lines       20596    20593       -3     
  Branches     2253     2253              
==========================================
- Hits        13311    13309       -2     
+ Misses       7162     7161       -1     
  Partials      123      123
Impacted Files Coverage Δ
superset/sql_lab.py 76.37% <0%> (-0.26%) ⬇️
superset/assets/src/explore/controls.jsx 42.4% <0%> (ø) ⬆️
.../src/explore/components/controls/SelectControl.jsx 83.52% <0%> (+0.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a717a90...7784e62. Read the comment docs.

Copy link
Contributor

@kristw kristw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉

@kristw kristw merged commit 149b31d into apache:master Apr 9, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants