Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when we try to use mapbox on a Druid datasource, it will show 'Invalid Choice' error of SelectField and "query() got an unexpected keyword argument 'columns'" due to the inconsistent interface between SqlTable and DruidDatasource. With this patch, mapbox still won't work on Druid, because you can not select columns in Druid queries. But at least it helps reducing some errors.
If I want to move one step forward, what can I do to make it work on Druid? Should I use metrics_combo as the choices of all_columns_x and all_columns_y instead of column_names?