Show scheduled queries #7521
Merged
Show scheduled queries #7521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betodealmeida
commented
May 16, 2019
| @@ -153,7 +153,7 @@ def json_response(self, obj, status=200): | |||
| status=status, | |||
| mimetype='application/json') | |||
|
|
|||
| def common_bootsrap_payload(self): | |||
There was a problem hiding this comment.
This made me super confused, since I was grepping for bootstrap and couldn't find this method!
Codecov Report
@@ Coverage Diff @@
## lyft-develop #7521 +/- ##
================================================
+ Coverage 65.29% 73.13% +7.84%
================================================
Files 432 84 -348
Lines 21386 11122 -10264
Branches 2357 0 -2357
================================================
- Hits 13963 8134 -5829
+ Misses 7303 2988 -4315
+ Partials 120 0 -120
Continue to review full report at Codecov.
|
khtruong
approved these changes
May 16, 2019
Merged
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
This PR shows scheduled information on saved queries that have them.
In order to do this, I created a custom template for showing the saved query, extending the native one from FAB. The template injects Javascript code and a
<div>, and the Javascript code inserts a<Form>component with the scheduled information.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
It looks ugly, but I'll fix the CSS in another PR:
TEST PLAN
Tested locally.
ADDITIONAL INFORMATION
REVIEWERS
@mistercrunch @datability-io @DiggidyDave @khtruong