Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add second and minute grains to sqlite #7810

Merged
merged 1 commit into from
Jul 3, 2019
Merged

Add second and minute grains to sqlite #7810

merged 1 commit into from
Jul 3, 2019

Conversation

villebro
Copy link
Member

@villebro villebro commented Jul 2, 2019

CATEGORY

  • Enhancement (new features, refinement)

SUMMARY

Sqlite was missing the common time grains of second and minute.

TEST PLAN

Tested locally.

@codecov-io
Copy link

Codecov Report

Merging #7810 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7810   +/-   ##
=======================================
  Coverage   65.89%   65.89%           
=======================================
  Files         459      459           
  Lines       22014    22014           
  Branches     2417     2417           
=======================================
  Hits        14507    14507           
  Misses       7386     7386           
  Partials      121      121
Impacted Files Coverage Δ
superset/db_engine_specs/sqlite.py 66.66% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56eac68...07319e9. Read the comment docs.

@villebro villebro merged commit 346638a into apache:master Jul 3, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants