[dashboard] fix chart showing loading icon when slice's immune fields is changed #7895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7895 +/- ##
=========================================
+ Coverage 65.79% 65.8% +0.01%
=========================================
Files 461 461
Lines 22188 22199 +11
Branches 2425 2433 +8
=========================================
+ Hits 14598 14608 +10
- Misses 7469 7470 +1
Partials 121 121
Continue to review full report at Codecov.
|
graceguo-supercat
force-pushed
the
gg-FixFilterImmuneFields
branch
3 times, most recently
from
1530d0e to
89f7c02
Compare
graceguo-supercat
force-pushed
the
gg-FixFilterImmuneFields
branch
from
89f7c02 to
f4b94a8
Compare
etr2460
reviewed
Jul 22, 2019
| const { filters } = this.props.dashboardState || {}; | ||
| const currentFilteredNames = | ||
| filterKey && filters[filterKey] ? Object.keys(filters[filterKey]) : []; | ||
| const filter_immune_slices = this.props.dashboardInfo.metadata |
| filterKey && filters[filterKey] ? Object.keys(filters[filterKey]) : []; | ||
| const filter_immune_slices = this.props.dashboardInfo.metadata | ||
| .filter_immune_slices; | ||
| const filter_immune_slice_fields = this.props.dashboardInfo.metadata |
| @@ -16,6 +16,7 @@ | |||
| * specific language governing permissions and limitations | |||
| * under the License. | |||
| */ | |||
| /* eslint-disable camelcase */ | |||
There was a problem hiding this comment.
then we can probably get rid of this comment
|
i am kind of hesitate to rename all
I would rather keep this PR simple, just for bug fixing. |
graceguo-supercat
changed the title
etr2460
approved these changes
Jul 24, 2019
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
When filter is changed, chart shows a loading icon, but not fetching data.
In Dashboard component, the logic to trigger chart refresh has problem. It only checks if whole chart is immune, but not check if chart immune to curtain fields in a applied filter.
After chart is triggered to refresh, its state changed from success to loading, so we show loading icon for the chart. But the effective filter for the chart is not changed (because filter is not applicable). At the result, chart didn't send new query, but since the chart did not change state any more, the chart's loading status will not disappear.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before:
after: should not show loading icon, and no fetching api call
TEST PLAN
Added new unit test for this case.
REVIEWERS
@williaster @michellethomas @mistercrunch @etr2460