[fix] bug on FixedOrMetricControl component causing issues with deck.gl polygon height + deck.gl scatter radius controls #7924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thunter009
changed the title
|
The master build was broken over the past few days because of travis changes, rebasing your PR should help. |
|
Should be good to go |
mistercrunch
approved these changes
Jul 29, 2019
|
Grateful for all your PRs @thunter009 , keep 'em comin'! |
2 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Fixes bugs causing FixedOrMetricControl to not render and then associated bugs in deck.gl polygon and deck.gl scatter causing map control functionality to break on input.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Slightly changed the UI of FixedOrMetricControl so it expands downward instead of as a pop-up as this was creating a double pop-up menu when Metric control was selected. See below for new UI:
TEST PLAN
Visual inspection
ADDITIONAL INFORMATION
REVIEWERS