Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve birth example dashboard #8042

Merged
merged 3 commits into from
Aug 19, 2019

Conversation

mistercrunch
Copy link
Member

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

The "Birth" dashboard had grown to something that didn't look that great over time. This makes the dashboard look decent, moving many charts towards the "Misc" dashboard.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

Screen Shot 2019-08-13 at 5 12 57 PM

after

Screen Shot 2019-08-13 at 5 02 03 PM

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer 👍

Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Aug 19, 2019

Codecov Report

Merging #8042 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8042      +/-   ##
==========================================
+ Coverage   65.57%   65.57%   +<.01%     
==========================================
  Files         469      469              
  Lines       22487    22496       +9     
  Branches     2446     2446              
==========================================
+ Hits        14745    14752       +7     
- Misses       7622     7624       +2     
  Partials      120      120
Impacted Files Coverage Δ
superset/examples/birth_names.py 100% <100%> (ø) ⬆️
superset/viz.py 71.27% <0%> (-0.32%) ⬇️
superset/connectors/sqla/models.py 84% <0%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51bd347...ad81a0a. Read the comment docs.

@mistercrunch mistercrunch merged commit 4e7ea3f into apache:master Aug 19, 2019
@mistercrunch mistercrunch deleted the improve_births branch August 19, 2019 05:36
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.35.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XL 🚢 0.35.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants