Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove idna req from setup.py/requirements.txt #8067

Merged
merged 1 commit into from
Aug 21, 2019

Conversation

DiggidyDave
Copy link
Contributor

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

This requirement seems to be no longer required, and it seems it was only added originally to pin its version to resolve conflicts that kept coming up. It is currently causing a conflict in our local installation at Lyft (due to interactions with requests and pydruid).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@betodealmeida @john-bodley @mistercrunch

@codecov-io
Copy link

codecov-io commented Aug 19, 2019

Codecov Report

Merging #8067 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8067   +/-   ##
=======================================
  Coverage   65.57%   65.57%           
=======================================
  Files         469      469           
  Lines       22496    22496           
  Branches     2446     2446           
=======================================
  Hits        14752    14752           
  Misses       7624     7624           
  Partials      120      120

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e7ea3f...247a9e5. Read the comment docs.

@DiggidyDave DiggidyDave deleted the removeIdnaReq branch August 19, 2019 20:21
@DiggidyDave DiggidyDave restored the removeIdnaReq branch August 19, 2019 21:58
@DiggidyDave DiggidyDave reopened this Aug 19, 2019
@DiggidyDave DiggidyDave reopened this Aug 19, 2019
@mistercrunch mistercrunch merged commit 995b96f into apache:master Aug 21, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.35.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.35.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants