-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Histogram visualization bug. #8077
Conversation
@kuckjwi0928 LGTM, but please run black on the PR to fix the CI error. |
Fixed it! |
It seems that it failed because of execution time limit. I guess it's ok to merge this PR. |
I restarted CI, let's merge once it completes if all is ok. |
Codecov Report
@@ Coverage Diff @@
## master #8077 +/- ##
==========================================
+ Coverage 65.57% 65.89% +0.31%
==========================================
Files 469 485 +16
Lines 22495 22917 +422
Branches 2448 2537 +89
==========================================
+ Hits 14752 15102 +350
- Misses 7620 7683 +63
- Partials 123 132 +9
Continue to review full report at Codecov.
|
This reverts commit 7ac1a29.
This reverts commit 7ac1a29.
Note: while this was later reverted in master after |
* Fix HistogramViz bug. * Fix ci black error.
This reverts commit b0d06a8.
CATEGORY
SUMMARY
Modified type mismatch bug in histogram visualization.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION
REVIEWERS
@mistercrunch