Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add explicit support for python 3.7 #8309

Merged
merged 1 commit into from
Sep 27, 2019
Merged

[docs] Add explicit support for python 3.7 #8309

merged 1 commit into from
Sep 27, 2019

Conversation

villebro
Copy link
Member

@villebro villebro commented Sep 27, 2019

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Currently the PyPI package only officially supports 3.6, and the documentation specifies that "running on 3.7 should work". As I've now been running 3.7 exclusively in dev for at least 6 months without any trouble, committing to officially supporting 3.7 should be safe.

REVIEWERS

@john-bodley @mistercrunch

@codecov-io
Copy link

codecov-io commented Sep 27, 2019

Codecov Report

Merging #8309 into master will decrease coverage by 5.79%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8309      +/-   ##
==========================================
- Coverage   73.53%   67.74%    -5.8%     
==========================================
  Files         115      451     +336     
  Lines       12396    22699   +10303     
  Branches        0     2370    +2370     
==========================================
+ Hits         9116    15378    +6262     
- Misses       3280     7184    +3904     
- Partials        0      137     +137
Impacted Files Coverage Δ
...sets/src/explore/components/ExploreChartHeader.jsx 50% <0%> (ø)
superset/assets/src/components/Checkbox.jsx 100% <0%> (ø)
...perset/assets/src/dashboard/util/getEmptyLayout.js 0% <0%> (ø)
...ts/src/dashboard/util/getComponentWidthFromDrop.js 95.23% <0%> (ø)
.../assets/src/dashboard/reducers/dashboardFilters.js 88.23% <0%> (ø)
...rc/explore/components/controls/AnnotationLayer.jsx 2.46% <0%> (ø)
superset/assets/src/welcome/DashboardTable.jsx 87.5% <0%> (ø)
...erset/assets/src/dashboard/util/injectCustomCss.js 91.66% <0%> (ø)
...explore/components/controls/ColorPickerControl.jsx 85% <0%> (ø)
...ets/src/dashboard/components/dnd/DragDroppable.jsx 94.59% <0%> (ø)
... and 326 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a8f3eb...50c9199. Read the comment docs.

@villebro villebro merged commit 52a84d2 into apache:master Sep 27, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.35.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.35.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants