Fix pypi link and replace gitter badge with slack #8330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etr2460
approved these changes
Oct 1, 2019
serenajiang
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Oct 9, 2019
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
The badge indicating supported python versions was referencing the old package
superset, notapache-superset. Also, as discussion has moved from gitter to slack, the gitter badge should be replaced with one referencing the slack workspace. Not sure about the color (just picked one that I found on google and modified accordingly).SCREENSHOT
TEST PLAN
Clicked both updated badges and verified visually that the new badges work.