-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SIP-15] Adding initial framework #8398
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -959,6 +959,9 @@ export const controls = { | |
'using the engine\'s local timezone. Note one can explicitly set the timezone ' + | ||
'per the ISO 8601 format if specifying either the start and/or end time.', | ||
), | ||
mapStateToProps: state => ({ | ||
endpoints: state.form_data ? state.form_data.time_range_endpoints : null, | ||
}), | ||
}, | ||
|
||
max_bubble_size: { | ||
|
@@ -2034,6 +2037,13 @@ export const controls = { | |
description: t('Extra parameters for use in jinja templated queries'), | ||
}, | ||
|
||
time_range_endpoints: { | ||
type: 'HiddenControl', | ||
label: t('Time range endpoints'), | ||
hidden: true, | ||
description: t('Time range endpoints (SIP-15)'), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we elaborate more about SIP-15 here? Provide a link or something? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @etr2460 this control is always hidden and only exists to ensure that associated form-data is preserved. |
||
}, | ||
|
||
order_by_entity: { | ||
type: 'CheckboxControl', | ||
label: t('Order by entity id'), | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove extra underscore here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@etr2460 see http://docutils.sourceforge.net/docs/user/rst/quickref.html#contents.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah i see.