[SIP-15] Fix time range endpoints decoding #8481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
changed the title
john-bodley
force-pushed
the
john-bodley--sip-15-fix-time-range-endpoints-encoding
branch
from
6defd98 to
6aa1661
Compare
Codecov Report
@@ Coverage Diff @@
## master #8481 +/- ##
==========================================
+ Coverage 66.54% 66.61% +0.06%
==========================================
Files 449 449
Lines 22609 22608 -1
Branches 2367 2367
==========================================
+ Hits 15046 15060 +14
+ Misses 7425 7410 -15
Partials 138 138
Continue to review full report at Codecov.
|
john-bodley
force-pushed
the
john-bodley--sip-15-fix-time-range-endpoints-encoding
branch
from
6aa1661 to
bd0fd40
Compare
john-bodley
commented
Oct 30, 2019
|
|
||
| if time_range_endpoints: | ||
| return time_range_endpoints | ||
| if slc and not endpoints: |
There was a problem hiding this comment.
This is really just a refactor of the old logic to ensure that we're not repeating ourselves when defining the interval.
john-bodley
force-pushed
the
john-bodley--sip-15-fix-time-range-endpoints-encoding
branch
from
bd0fd40 to
6e2f440
Compare
john-bodley
added a commit
to john-bodley/superset
that referenced
this pull request
Oct 31, 2019
(cherry picked from commit eb150eb)
graceguo-supercat
pushed a commit
that referenced
this pull request
Nov 13, 2019
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Python tuples (which is how the time range endpoints are defined) are encoded as JSON arrays and thus when the form data is decoded we need to re-encode this as a tuple especially for comparison reasons.
This PR also ensures that the endpoints if present in the JSON form-data are decoded using the enum (as opposed to string) for consistency.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
Manual testing.
ADDITIONAL INFORMATION
REVIEWERS
to: @etr2460 @graceguo-supercat @michellethomas @villbro