Replace hardcoded default colors with defaults in setupColors.js #8510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graceguo-supercat
pushed a commit
that referenced
this pull request
Nov 13, 2019
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Currently the default colors for both categorical and sequential schemes are hardcoded in
controls.js, which means that changing the default values insetupColors.jsdon't have any effect on the default color scheme. This PR changescontrols.jsto use the default scheme as defined insetupColors.js, and also sets the default key forsequentialSchemeRegistry(previously only hard coded incontrols.js).TEST PLAN
Tested locally by changing the default key in
setupColors.js, and verifying that the default colors in a test dashboard reflected the change. If needed I can look into adding tests for this.REVIEWERS
@etr2460 @mistercrunch @graceguo-supercat