[dashboard] fix, enable info endpoint #9015
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9015 +/- ##
=======================================
Coverage 59.15% 59.15%
=======================================
Files 367 367
Lines 11682 11682
Branches 2864 2864
=======================================
Hits 6910 6910
Misses 4593 4593
Partials 179 179Continue to review full report at Codecov.
|
| @@ -58,4 +59,4 @@ class RouteMethod: # pylint: disable=too-few-public-methods | |||
| # Commonly used sets | |||
| CRUD_SET = {ADD, LIST, EDIT, DELETE, ACTION_POST} | |||
| RELATED_VIEW_SET = {ADD, LIST, EDIT, DELETE} | |||
| REST_MODEL_VIEW_CRUD_SET = {DELETE, GET, GET_LIST, POST, PUT} | |||
| REST_MODEL_VIEW_CRUD_SET = {DELETE, GET, GET_LIST, POST, PUT, INFO} | |||
There was a problem hiding this comment.
I'm a little concerned with this pattern overall. Altering these "defaults" down the road could lead to unintended side effects.
There was a problem hiding this comment.
We can remove it from the default and enable the info endpoint on a per-case basis. That was the original approach: a5488e2
but it seems like we'll need to info endpoint in most cases
|
i'm going to merge this to unbreak master. We can make necessary fixes next week. I'm choosing this approach over reverting the API change PR as that one was tagged as a security PR |
* [dashboard] fix, enable info endpoint * add info to REST_MODEL_VIEW_CRUD_SET (cherry picked from commit c552c85)
mistercrunch
added
🏷️ bot
CATEGORY
Choose one
SUMMARY
The new dashboard list view #8845 depends on the info endpoint to generate filters and check delete/export permissions. It seems it was disabled in the recent work to remove unused routes. This PR re-enabled that endpoint for the rest apis.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
_infoendpoint does not error out on loading the dashboard list view.ADDITIONAL INFORMATION
REVIEWERS
@dpgaspar @mistercrunch