[dashboard] fix filter_scopes when copy dashboard with duplicate_slices #9188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graceguo-supercat
force-pushed
the
gg-FixCopyDashFilterScopes
branch
from
f1f2682 to
eb04f8a
Compare
Codecov Report
@@ Coverage Diff @@
## master #9188 +/- ##
==========================================
- Coverage 59.16% 59.13% -0.04%
==========================================
Files 372 372
Lines 11935 11938 +3
Branches 2927 2925 -2
==========================================
- Hits 7061 7059 -2
- Misses 4694 4699 +5
Partials 180 180
Continue to review full report at Codecov.
|
serenajiang
reviewed
Feb 22, 2020
| @@ -1195,6 +1195,20 @@ def copy_dash(self, dashboard_id): | |||
| old_id = "{}".format(value.get("meta").get("chartId")) | |||
| new_id = int(old_to_new_sliceids[old_id]) | |||
| value["meta"]["chartId"] = new_id | |||
|
|
|||
| if "filter_scopes" in data: | |||
There was a problem hiding this comment.
This looks pretty similar to the chunk of code here. Can we pull this out into a function?
There was a problem hiding this comment.
added a util function to clean up.
serenajiang
approved these changes
Feb 24, 2020
12 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
When user copy dashboard with
also copy (duplicate) charts, dashboard duplicates each slices in the old dash and use new slice_id in the new dash. We should update filter_scopes with new slice ids.TEST PLAN
CI and manual test
ADDITIONAL INFORMATION
REVIEWERS
@serenajiang @john-bodley