Add explore control tabOverride at the section level #9495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristw
approved these changes
Apr 9, 2020
| if ( | ||
| section.tabOverride === 'data' || |
There was a problem hiding this comment.
The lines 208-210 below should be changed to account for control potentially being a string or an object, right? I wouldn't block this PR on that change since we want to get the fix in, just making a note because it might cause this issue again in the future.
There was a problem hiding this comment.
Yes, I think we should preprocess the configs at some point and avoid accounting for two types. I'll see what I can do later.
|
Thanks for fixing this! |
|
Thanks for catching this AND for fixing it! I'll keep an eye out for this in the future. |
6 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
SUMMARY
#9440 unintentionally moved the "Options" section for Big Number chart to the "Customize" tab.
This is because ControlPanelsContainer checks whether a section needs to display in the Data tab by checking whether any of the control in that section must trigger new queries when updated (
renderTrigger: false) or hastabOverride = data. But it uses the config in the shared controls file, and assumes the control configs passed along are names of the shared controls, and could be used to look up the shared control from controls.jsx. However, when these controls are refactored into custom configs, they become objects andControlPanelsContainerthen fails to find the shared control, hence therenderTriggerandtabOverrideinfo.Ideally this
tabOverrideoption should probably be at the section level.A bigger refactor is need to let
ControlPanelsContaineralways read from parsed control configs (instead of the control keys). This PR is just a quick fix.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
The "Options" section is displayed in the "Customize" tab.
After
The "Options" section is displayed in the "Data" tab like before.
TEST PLAN
ADDITIONAL INFORMATION
REVIEWERS
@rusackas @michellethomas