[SYSTEMDS-3240] Fix IOGEN test path if the iogen directory doesn't exist #1475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems, a test related to this fails. Running org.apache.sysds.test.functions.iogen.FrameGenerateReaderCSVTest
java.lang.Exception: The file format couldn't recognize!!
at org.apache.sysds.runtime.iogen.GenerateReader$GenerateReaderFrame.getReader(GenerateReader.java:114)
at org.apache.sysds.test.functions.iogen.GenerateReaderFrameTest.runGenerateReaderTest(GenerateReaderFrameTest.java:180) |
j143
changed the title
Thanks, @j143 - I fixed the tests and run all of them multiple times. The errors come up when I generate data with a random function; it seems some values had bad formats. |
j143
approved these changes
Dec 7, 2021
There was a problem hiding this comment.
Thank you, @fathollahzadeh - LGTM. 👍 🎉 🚀
Worked fine on my machine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes "iogen" directory in "/test/scripts/functions" path when we don't have it.