[MINOR] Frame Float detection refinement #1896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baunsgaard
force-pushed
the
FrameFloatDetectionImprovements
branch
from
b8acfb0 to
b20f2b8
Compare
|
depends on #1895 |
This commit refine the detection and selection of float values in the schema detection algorithm located in: src/main/java/org/apache/sysds/runtime/frame/data/lib/FrameUtil.java To improve the performance a custom matcher have been made to avoid using regexes if possible, and we try to avoid parsing the float value from the string representation if at all possible. The implementation is not completely fool proof and does not consider many adversarial inputs. on a small test case of 1000 string values that all are fp32 the implementation improve performance from 0.5 ms to 0.02 ms.
Baunsgaard
force-pushed
the
FrameFloatDetectionImprovements
branch
from
b20f2b8 to
4851f34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refine the detection and selection of float values in the schema detection algorithm located in:
src/main/java/org/apache/sysds/runtime/frame/data/lib/FrameUtil.java
To improve the performance a custom matcher have been made to avoid using regexes if possible, and we try to avoid parsing the float value from the string representation if at all possible. The implementation is not completely fool proof and does not consider many adversarial inputs.