-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYSTEMDS-3636] Improved ultra-sparse tsmm left w/ sparse output #1955
[SYSTEMDS-3636] Improved ultra-sparse tsmm left w/ sparse output #1955
Conversation
how much faster is it? |
@Baunsgaard I only tested the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few comments for improvements, hope you can decrypt it.
src/main/java/org/apache/sysds/runtime/matrix/data/LibMatrixMult.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/sysds/runtime/matrix/data/LibMatrixMult.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/sysds/runtime/matrix/data/LibMatrixMult.java
Outdated
Show resolved
Hide resolved
After the changes the runtime of the |
src/main/java/org/apache/sysds/runtime/matrix/data/LibMatrixMult.java
Outdated
Show resolved
Hide resolved
LGTM |
Thanks for the PR, it is now merged! |
This patch provides the support for left transposed ultra-sparse tsmm.
Similar to the the implementation of the right transpose ultra-sparse tsmm,
binary search is used to populate the upper triangular part of a sparse output matrix.