TEZ-4339: Expose real-time memory consumption of AM and task containers via DagClient #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
rbalamohan
reviewed
Oct 25, 2021
tez-runtime-internals/src/main/java/org/apache/tez/runtime/task/TaskReporter.java
Outdated
Show resolved
Hide resolved
rbalamohan
reviewed
Oct 25, 2021
tez-runtime-internals/src/main/java/org/apache/tez/runtime/task/TaskReporter.java
Outdated
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
rbalamohan
reviewed
Oct 31, 2021
| @@ -61,6 +61,13 @@ public void addVertexProgress(String name, ProgressBuilder progress) { | |||
| getBuilder().addVertexProgress(builder.build()); | |||
| } | |||
|
|
|||
| //TODO: let this be a map of values in protobuf 3.x | |||
There was a problem hiding this comment.
What is this todo for? or am i missing something here?
There was a problem hiding this comment.
I wanted to put these memory related stuff into a map, which can be dinamically extended later with other metrics if needed, but unfortunately the protoc compiler which is used in protobuf 2.5 doesn't support maps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.