Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEZ-4347: Add some diagnostic endpoints to TezAM's WebUIService #160

Merged
merged 1 commit into from
May 4, 2022

Conversation

abstractdog
Copy link
Contributor

@abstractdog abstractdog commented Nov 11, 2021

Add some diagnostic endpoints to TezAM's WebUIService

  • add new endpoints to webuiservice
  • make port range configurable
  • publish the web endpoint through dag client
  • unit test included: TestAM
  • checked in browser too

@tez-yetus

This comment has been minimized.

@tez-yetus

This comment has been minimized.

@tez-yetus

This comment has been minimized.

@tez-yetus

This comment has been minimized.

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@abstractdog
Copy link
Contributor Author

could you please review this @jteagles , @zjffdu? a medium size patch for adding new features to tez am web ui service

@tez-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 16m 29s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 prototool 0m 0s prototool was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+0 🆗 mvndep 5m 5s Maven dependency ordering for branch
+1 💚 mvninstall 9m 48s master passed
+1 💚 compile 2m 31s master passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚 compile 2m 17s master passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 checkstyle 2m 5s master passed
+1 💚 javadoc 2m 27s master passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 2m 7s master passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 🆗 spotbugs 0m 43s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 4m 39s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 9s Maven dependency ordering for patch
+1 💚 mvninstall 1m 39s the patch passed
+1 💚 compile 1m 48s the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚 cc 1m 48s the patch passed
+1 💚 javac 1m 48s the patch passed
+1 💚 compile 1m 35s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 cc 1m 35s the patch passed
+1 💚 javac 1m 35s the patch passed
-0 ⚠️ checkstyle 0m 8s tez-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 1m 30s the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 1m 23s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 findbugs 4m 14s the patch passed
_ Other Tests _
+1 💚 unit 2m 1s tez-api in the patch passed.
+1 💚 unit 0m 24s tez-common in the patch passed.
+1 💚 unit 1m 12s tez-mapreduce in the patch passed.
+1 💚 unit 4m 16s tez-dag in the patch passed.
+1 💚 unit 38m 56s tez-tests in the patch passed.
+1 💚 asflicense 0m 58s The patch does not generate ASF License warnings.
110m 22s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-160/10/artifact/out/Dockerfile
GITHUB PR #160
JIRA Issue TEZ-4347
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile cc prototool
uname Linux 0f5a1586d607 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / f724c54
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-160/10/artifact/out/diff-checkstyle-tez-common.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-160/10/testReport/
Max. process+thread count 1214 (vs. ulimit of 5500)
modules C: tez-api tez-common tez-mapreduce tez-dag tez-tests U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-160/10/console
versions git=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog
Copy link
Contributor Author

please review this @rbalamohan , @jteagles, thanks in advance!
tested locally, we would like this patch to be the base of further improvements like TEZ-4038, so we're kind of blocked here

@rbalamohan
Copy link
Contributor

LGTM. +1. This can serve as the base for adding "/prof" endpoint in AM later.

@abstractdog abstractdog merged commit 798ddda into apache:master May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants