TEZ-4357: Report url to logs in case of fetcher connection failure #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Feb 10, 2022
ayushtkn
reviewed
Aug 8, 2022
| "Fetch Failure while connecting from %s to: %s:%d, attempt: %s Informing ShuffleManager: ", | ||
| localHostname, host, port, firstAttempt), e); | ||
| "Fetch Failure while connecting from %s to: %s:%d, attempt: %s, url: %s Informing ShuffleManager", | ||
| localHostname, host, port, firstAttempt, baseURI.toString()), e); |
There was a problem hiding this comment.
Do we need to call toString() here, %s can take any type & the output is always string right? BTW why aren't we using Logger format here like {} instead of String.format?
There was a problem hiding this comment.
using {} format would make sense but we cannot mix the format arguments and exception in any of the LOG.warn methods
toString can be removed yeah
UPDATE: oh wait, just checked, last argument of vararg is a throwable candidate, so we can use formats here|
public void warn(String format, Object... argArray) {
if (logger.isEnabledFor(Level.WARN)) {
FormattingTuple ft = MessageFormatter.arrayFormat(format, argArray);
logger.log(FQCN, Level.WARN, ft.getMessage(), ft.getThrowable());
}
}
abstractdog
force-pushed
the
TEZ-4357
branch
2 times, most recently
from
8fd6d0f to
36559df
Compare
|
addressed comments + added a "FETCH_FAILURE" log prefix which is common for Fetcher and FetcherOrderedGrouped, so makes it easier to scan through app logs for fetch failures |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
abstractdog
force-pushed
the
TEZ-4357
branch
from
36559df to
2b71130
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.