Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEZ-4366: Disk utilization limit fix should be applied to all tez mini clusters #173

Merged
merged 2 commits into from
Jan 21, 2022

Conversation

abstractdog
Copy link
Contributor

No description provided.

@tez-yetus

This comment has been minimized.

@tez-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 30s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+0 🆗 mvndep 4m 19s Maven dependency ordering for branch
+1 💚 mvninstall 9m 9s master passed
+1 💚 compile 1m 30s master passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚 compile 1m 26s master passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 checkstyle 1m 29s master passed
+1 💚 javadoc 1m 33s master passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 1m 16s master passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 🆗 spotbugs 0m 41s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 2m 25s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 9s Maven dependency ordering for patch
+1 💚 mvninstall 0m 49s the patch passed
+1 💚 compile 0m 48s the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚 javac 0m 48s the patch passed
+1 💚 compile 0m 45s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 javac 0m 45s the patch passed
+1 💚 checkstyle 0m 10s The patch passed checkstyle in tez-common
+1 💚 checkstyle 0m 11s tez-tests: The patch generated 0 new + 3 unchanged - 1 fixed = 3 total (was 4)
+1 💚 checkstyle 0m 8s The patch passed checkstyle in tez-yarn-timeline-history
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 39s the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 0m 34s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 findbugs 1m 45s the patch passed
_ Other Tests _
+1 💚 unit 0m 32s tez-common in the patch passed.
+1 💚 unit 44m 12s tez-tests in the patch passed.
+1 💚 unit 1m 32s tez-yarn-timeline-history in the patch passed.
+1 💚 asflicense 0m 34s The patch does not generate ASF License warnings.
77m 52s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-173/2/artifact/out/Dockerfile
GITHUB PR #173
JIRA Issue TEZ-4366
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux fd67ca86a151 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 7e09dfa
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-173/2/testReport/
Max. process+thread count 1341 (vs. ulimit of 5500)
modules C: tez-common tez-tests tez-plugins/tez-yarn-timeline-history U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-173/2/console
versions git=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog abstractdog requested a review from jteagles January 5, 2022 15:01
@abstractdog
Copy link
Contributor Author

thanks for the review @shameersss1, in order to merge it, officially a committer +1 is needed, but I appreciate you've already taken a look at this one!

@jteagles
Copy link
Contributor

jteagles commented Jan 5, 2022

Thanks, @abstractdog. I can see the value in this. I wonder if this method is better suited to a test utility, though I can't seem to find one. I can see this going in as is or Trying to find a class that is utilities just for tests. Let me know what you want.

@tez-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 12m 44s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+0 🆗 mvndep 4m 33s Maven dependency ordering for branch
+1 💚 mvninstall 9m 19s master passed
+1 💚 compile 1m 32s master passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚 compile 1m 28s master passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 checkstyle 1m 30s master passed
+1 💚 javadoc 1m 31s master passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 1m 18s master passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 🆗 spotbugs 0m 41s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 2m 26s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for patch
+1 💚 mvninstall 0m 49s the patch passed
+1 💚 compile 0m 49s the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚 javac 0m 49s the patch passed
+1 💚 compile 0m 46s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 javac 0m 46s the patch passed
-0 ⚠️ checkstyle 0m 10s tez-common: The patch generated 1 new + 56 unchanged - 0 fixed = 57 total (was 56)
+1 💚 checkstyle 0m 11s tez-tests: The patch generated 0 new + 3 unchanged - 1 fixed = 3 total (was 4)
+1 💚 checkstyle 0m 9s The patch passed checkstyle in tez-yarn-timeline-history
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 39s the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 0m 35s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 findbugs 1m 45s the patch passed
_ Other Tests _
+1 💚 unit 0m 32s tez-common in the patch passed.
+1 💚 unit 44m 23s tez-tests in the patch passed.
+1 💚 unit 1m 32s tez-yarn-timeline-history in the patch passed.
+1 💚 asflicense 0m 35s The patch does not generate ASF License warnings.
90m 54s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-173/3/artifact/out/Dockerfile
GITHUB PR #173
JIRA Issue TEZ-4366
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux e4678e8b1473 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 227c750
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-173/3/artifact/out/diff-checkstyle-tez-common.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-173/3/testReport/
Max. process+thread count 1329 (vs. ulimit of 5500)
modules C: tez-common tez-tests tez-plugins/tez-yarn-timeline-history U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-173/3/console
versions git=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog
Copy link
Contributor Author

@jteagles : could this be committed?

Copy link
Contributor

@jteagles jteagles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@jteagles jteagles merged commit 267ca11 into apache:master Jan 21, 2022
asfgit pushed a commit that referenced this pull request Jan 23, 2022
…i clusters (#173)

* TEZ-4366: Disk utilization limit fix should be applied to all tez mini clusters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants