TEZ-4441: TezAppMaster may stuck because of reportError skip send err… #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
abstractdog
reviewed
Aug 19, 2022
| @@ -910,7 +910,8 @@ public void reportError(int taskSchedulerIndex, ServicePluginError servicePlugin | |||
| LOG.info("Error reported by scheduler {} - {}", | |||
| Utils.getTaskSchedulerIdentifierString(taskSchedulerIndex, appContext) + ": " + | |||
| diagnostics); | |||
| if (taskSchedulerDescriptors[taskSchedulerIndex].getClassName().equals(yarnSchedulerClassName)) { | |||
| if (taskSchedulerDescriptors[taskSchedulerIndex].getEntityName() | |||
There was a problem hiding this comment.
I guess this is the actual fix
just a note, what are the values in your case:
taskSchedulerDescriptors[taskSchedulerIndex].getClassName()
yarnSchedulerClassName
taskSchedulerDescriptors[taskSchedulerIndex].getEntityName()
There was a problem hiding this comment.
Yes, this is the only actual fix.
- Before this PR
| method | return value |
|---|---|
| taskSchedulerDescriptors[taskSchedulerIndex].getClassName() | null |
| yarnSchedulerClassName | "org.apache.tez.dag.app.rm.YarnTaskSchedulerService" |
taskSchedulerDescriptors[taskSchedulerIndex].getClassName() is set from the variable 'taskSchedulerDescriptors' of DAGAppMaster::serviceInit. In DAGAppMaster::parsePlugin, when we construct NamedEntityDescriptor for tez yarn plugin, the className is all null.
yarnSchedulerClassName is set from tez.am.yarn.scheduler.class, default value is "org.apache.tez.dag.app.rm.YarnTaskSchedulerService".
So for tez yarn plugin, taskSchedulerDescriptors[taskSchedulerIndex].getClassName() will never equals to yarnSchedulerClassName. Then
- After this PR
taskSchedulerDescriptors[taskSchedulerIndex].getEntityName() will return "TezYarn"
There was a problem hiding this comment.
I see, nice catch:
we simply don't fill the classname, so we should not rely on it, only use it in case of createCustomTaskScheduler
abstractdog
reviewed
Aug 19, 2022
tez-dag/src/test/java/org/apache/tez/dag/app/rm/TestTaskSchedulerManager.java
Outdated
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
asfgit
pushed a commit
that referenced
this pull request
Aug 29, 2022
…or event (#236) (zhengchenyu reviewed by Laszlo Bodor)
udaynpusa
pushed a commit
to mapr/tez
that referenced
this pull request
Jan 30, 2024
…or event (apache#236) (zhengchenyu reviewed by Laszlo Bodor) (cherry picked from commit 55b6031)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TEZ-4441