Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEZ-4454: remove extra semicolons #246

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Conversation

slfan1989
Copy link
Contributor

@slfan1989 slfan1989 commented Nov 3, 2022

JIRA: TEZ-4454: remove extra commas.

While reading the code, I found that there are extra commas in the code, I searched the whole project and removed the extra commas.

@tez-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 36m 35s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 3 new or modified test files.
_ master Compile Tests _
+0 🆗 mvndep 6m 1s Maven dependency ordering for branch
+1 💚 mvninstall 11m 15s master passed
+1 💚 compile 2m 57s master passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚 compile 2m 43s master passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚 checkstyle 2m 40s master passed
+1 💚 javadoc 2m 48s master passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 2m 32s master passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+0 🆗 spotbugs 0m 54s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 5m 5s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for patch
+1 💚 mvninstall 1m 35s the patch passed
+1 💚 compile 1m 47s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚 javac 1m 47s the patch passed
+1 💚 compile 1m 30s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚 javac 1m 30s the patch passed
+1 💚 checkstyle 0m 13s The patch passed checkstyle in tez-api
+1 💚 checkstyle 0m 19s tez-runtime-library: The patch generated 0 new + 137 unchanged - 2 fixed = 137 total (was 139)
+1 💚 checkstyle 0m 26s tez-dag: The patch generated 0 new + 281 unchanged - 3 fixed = 281 total (was 284)
+1 💚 checkstyle 0m 13s tez-tests: The patch generated 0 new + 43 unchanged - 2 fixed = 43 total (was 45)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 1m 28s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 1m 24s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚 findbugs 4m 8s the patch passed
_ Other Tests _
+1 💚 unit 2m 13s tez-api in the patch passed.
+1 💚 unit 5m 26s tez-runtime-library in the patch passed.
+1 💚 unit 5m 9s tez-dag in the patch passed.
+1 💚 unit 40m 56s tez-tests in the patch passed.
+1 💚 asflicense 0m 53s The patch does not generate ASF License warnings.
142m 4s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-246/1/artifact/out/Dockerfile
GITHUB PR #246
JIRA Issue TEZ-4454
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux bb3c9bb0f70e 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 8ebc4b0
Default Java Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-246/1/testReport/
Max. process+thread count 1217 (vs. ulimit of 5500)
modules C: tez-api tez-runtime-library tez-dag tez-tests U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-246/1/console
versions git=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@slfan1989
Copy link
Contributor Author

@abstractdog Can you help review this pr? Thank you very much!

@abstractdog
Copy link
Contributor

LGTM +1
fixing this to "semicolons" instead of "commas"

@abstractdog abstractdog changed the title TEZ-4454: remove extra commas. TEZ-4454: remove extra semicolons Nov 4, 2022
@abstractdog abstractdog self-requested a review November 4, 2022 06:52
@abstractdog abstractdog merged commit 8bb27b8 into apache:master Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants