Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEZ-4455: Add LoggingHandler in ShuffleHandler pipeline for better debuggability #249

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

difin
Copy link
Contributor

@difin difin commented Nov 22, 2022

What changes were proposed in this pull request?
Adding LoggingHandler in ShuffleHandler pipeline for better debuggability.

Why are the changes needed?
For corner case debugging, it will be helpful to understand when netty processed OPEN/BOUND/CLOSE/RECEIVED/CONNECTED events along with payload details.
Adding "LoggingHandler" in ChannelPipeline mode to help in debugging.

Does this PR introduce any user-facing change?
No.

How was this patch tested?
Pre-commit testing.

@tez-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 28s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 15m 31s master passed
+1 💚 compile 0m 42s master passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚 compile 0m 40s master passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚 checkstyle 1m 11s master passed
+1 💚 javadoc 0m 46s master passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚 javadoc 0m 36s master passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+0 🆗 spotbugs 1m 14s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 1m 11s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 27s the patch passed
+1 💚 compile 0m 19s the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚 javac 0m 19s the patch passed
+1 💚 compile 0m 18s the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚 javac 0m 18s the patch passed
+1 💚 checkstyle 0m 11s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 14s the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚 javadoc 0m 13s the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚 findbugs 0m 35s the patch passed
_ Other Tests _
+1 💚 unit 2m 51s tez-aux-services in the patch passed.
+1 💚 asflicense 0m 16s The patch does not generate ASF License warnings.
27m 27s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-249/1/artifact/out/Dockerfile
GITHUB PR #249
JIRA Issue TEZ-4455
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux f2e7d93761fd 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 8bb27b8
Default Java Private Build-1.8.0_352-8u352-ga-1~20.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-249/1/testReport/
Max. process+thread count 1504 (vs. ulimit of 5500)
modules C: tez-plugins/tez-aux-services U: tez-plugins/tez-aux-services
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-249/1/console
versions git=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog abstractdog self-requested a review November 23, 2022 19:24
Copy link
Contributor

@abstractdog abstractdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@abstractdog abstractdog changed the title TEZ-4455: Add LoggingHandler in ShuffleHandler pipeline for better de… TEZ-4455: Add LoggingHandler in ShuffleHandler pipeline for better debuggability Nov 23, 2022
@abstractdog abstractdog merged commit 65f9ee3 into apache:master Nov 23, 2022
prabhjyotsingh pushed a commit to acceldata-io/tez that referenced this pull request Nov 11, 2024
…buggability. (apache#249) (Dmitriy Fingerman reviewed by Laszlo Bodor)

(cherry picked from commit 65f9ee3)
prabhjyotsingh pushed a commit to acceldata-io/tez that referenced this pull request Nov 12, 2024
…buggability. (apache#249) (Dmitriy Fingerman reviewed by Laszlo Bodor)

(cherry picked from commit 65f9ee3)
prabhjyotsingh pushed a commit to acceldata-io/tez that referenced this pull request Nov 12, 2024
…buggability. (apache#249) (Dmitriy Fingerman reviewed by Laszlo Bodor)

(cherry picked from commit 65f9ee3)
(cherry picked from commit 2c2be57)
prabhjyotsingh pushed a commit to acceldata-io/tez that referenced this pull request Nov 12, 2024
…buggability. (apache#249) (Dmitriy Fingerman reviewed by Laszlo Bodor)

(cherry picked from commit 65f9ee3)
(cherry picked from commit 2c2be57)
prabhjyotsingh pushed a commit to acceldata-io/tez that referenced this pull request Nov 12, 2024
…buggability. (apache#249) (Dmitriy Fingerman reviewed by Laszlo Bodor)

(cherry picked from commit 65f9ee3)
(cherry picked from commit 2c2be57)
prabhjyotsingh pushed a commit to acceldata-io/tez that referenced this pull request Nov 12, 2024
…buggability. (apache#249) (Dmitriy Fingerman reviewed by Laszlo Bodor)

(cherry picked from commit 65f9ee3)
(cherry picked from commit 2c2be57)
prabhjyotsingh pushed a commit to acceldata-io/tez that referenced this pull request Nov 12, 2024
…buggability. (apache#249) (Dmitriy Fingerman reviewed by Laszlo Bodor)

(cherry picked from commit 65f9ee3)
(cherry picked from commit 2c2be57)
prabhjyotsingh pushed a commit to acceldata-io/tez that referenced this pull request Nov 20, 2024
…buggability. (apache#249) (Dmitriy Fingerman reviewed by Laszlo Bodor)

(cherry picked from commit 65f9ee3)
(cherry picked from commit 2c2be57)
(cherry picked from commit 12be783)
prabhjyotsingh added a commit to acceldata-io/tez that referenced this pull request Nov 20, 2024
… better debuggability. (apache#249) (Dmitriy Fingerman reviewed by Laszlo Bodor) (#21)

(cherry picked from commit 65f9ee3)
(cherry picked from commit 2c2be57)
(cherry picked from commit 12be783)

Co-authored-by: Dmitriy Fingerman <[email protected]>
shubhluck pushed a commit to acceldata-io/tez that referenced this pull request Nov 21, 2024
… better debuggability. (apache#249) (Dmitriy Fingerman reviewed by Laszlo Bodor) (#21)

(cherry picked from commit 65f9ee3)
(cherry picked from commit 2c2be57)
(cherry picked from commit 12be783)

Co-authored-by: Dmitriy Fingerman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants