-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEZ-4455: Add LoggingHandler in ShuffleHandler pipeline for better debuggability #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 -1 overall
This message was automatically generated. |
abstractdog
approved these changes
Nov 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
abstractdog
changed the title
TEZ-4455: Add LoggingHandler in ShuffleHandler pipeline for better de…
TEZ-4455: Add LoggingHandler in ShuffleHandler pipeline for better debuggability
Nov 23, 2022
prabhjyotsingh
pushed a commit
to acceldata-io/tez
that referenced
this pull request
Nov 11, 2024
…buggability. (apache#249) (Dmitriy Fingerman reviewed by Laszlo Bodor) (cherry picked from commit 65f9ee3)
prabhjyotsingh
pushed a commit
to acceldata-io/tez
that referenced
this pull request
Nov 12, 2024
…buggability. (apache#249) (Dmitriy Fingerman reviewed by Laszlo Bodor) (cherry picked from commit 65f9ee3)
prabhjyotsingh
pushed a commit
to acceldata-io/tez
that referenced
this pull request
Nov 12, 2024
…buggability. (apache#249) (Dmitriy Fingerman reviewed by Laszlo Bodor) (cherry picked from commit 65f9ee3) (cherry picked from commit 2c2be57)
prabhjyotsingh
pushed a commit
to acceldata-io/tez
that referenced
this pull request
Nov 12, 2024
…buggability. (apache#249) (Dmitriy Fingerman reviewed by Laszlo Bodor) (cherry picked from commit 65f9ee3) (cherry picked from commit 2c2be57)
prabhjyotsingh
pushed a commit
to acceldata-io/tez
that referenced
this pull request
Nov 12, 2024
…buggability. (apache#249) (Dmitriy Fingerman reviewed by Laszlo Bodor) (cherry picked from commit 65f9ee3) (cherry picked from commit 2c2be57)
prabhjyotsingh
pushed a commit
to acceldata-io/tez
that referenced
this pull request
Nov 12, 2024
…buggability. (apache#249) (Dmitriy Fingerman reviewed by Laszlo Bodor) (cherry picked from commit 65f9ee3) (cherry picked from commit 2c2be57)
prabhjyotsingh
pushed a commit
to acceldata-io/tez
that referenced
this pull request
Nov 12, 2024
…buggability. (apache#249) (Dmitriy Fingerman reviewed by Laszlo Bodor) (cherry picked from commit 65f9ee3) (cherry picked from commit 2c2be57)
prabhjyotsingh
pushed a commit
to acceldata-io/tez
that referenced
this pull request
Nov 20, 2024
…buggability. (apache#249) (Dmitriy Fingerman reviewed by Laszlo Bodor) (cherry picked from commit 65f9ee3) (cherry picked from commit 2c2be57) (cherry picked from commit 12be783)
prabhjyotsingh
added a commit
to acceldata-io/tez
that referenced
this pull request
Nov 20, 2024
… better debuggability. (apache#249) (Dmitriy Fingerman reviewed by Laszlo Bodor) (#21) (cherry picked from commit 65f9ee3) (cherry picked from commit 2c2be57) (cherry picked from commit 12be783) Co-authored-by: Dmitriy Fingerman <[email protected]>
shubhluck
pushed a commit
to acceldata-io/tez
that referenced
this pull request
Nov 21, 2024
… better debuggability. (apache#249) (Dmitriy Fingerman reviewed by Laszlo Bodor) (#21) (cherry picked from commit 65f9ee3) (cherry picked from commit 2c2be57) (cherry picked from commit 12be783) Co-authored-by: Dmitriy Fingerman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adding LoggingHandler in ShuffleHandler pipeline for better debuggability.
Why are the changes needed?
For corner case debugging, it will be helpful to understand when netty processed OPEN/BOUND/CLOSE/RECEIVED/CONNECTED events along with payload details.
Adding "LoggingHandler" in ChannelPipeline mode to help in debugging.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pre-commit testing.