Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEZ-4464: Update some links to https #260

Merged
merged 1 commit into from
Jan 2, 2023

Conversation

raboof
Copy link
Member

@raboof raboof commented Dec 23, 2022

No description provided.

@tez-yetus

This comment was marked as outdated.

@abstractdog
Copy link
Contributor

thanks for this contribution @raboof , can you please create jira also?
https://issues.apache.org/jira/projects/TEZ/

@raboof raboof force-pushed the https-links branch 2 times, most recently from 13ac301 to 9b20e8a Compare December 23, 2022 12:45
@raboof raboof changed the title Update some links to https [TEZ-4464] Update some links to https Dec 23, 2022
@raboof raboof changed the title [TEZ-4464] Update some links to https TEZ-4464: Update some links to https Dec 23, 2022
@raboof
Copy link
Member Author

raboof commented Dec 23, 2022

Please justify why no new tests are needed for this patch.

no tests were added because adding a link checker to the CI seems beyond the scope of this PR.

Also please list what manual steps were performed to verify this patch.

I manually followed most updated links to verify the linked sites indeed support https. I did not verify the pages still serve useful content.

can you please create jira also?

Sure, done!

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@tez-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 39m 40s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 18m 9s master passed
+1 💚 compile 0m 20s master passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚 compile 0m 17s master passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚 mvnsite 0m 21s master passed
+1 💚 javadoc 0m 39s master passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚 javadoc 0m 19s master passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
_ Patch Compile Tests _
+1 💚 mvninstall 0m 8s the patch passed
+1 💚 compile 0m 8s the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚 javac 0m 8s the patch passed
+1 💚 compile 0m 7s the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚 javac 0m 7s the patch passed
-1 ❌ markdownlint 0m 7s The patch generated 2 new + 195 unchanged - 2 fixed = 197 total (was 197)
+1 💚 mvnsite 0m 7s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 3s The patch has no ill-formed XML file.
+1 💚 javadoc 0m 8s the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚 javadoc 0m 8s the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
_ Other Tests _
+1 💚 unit 0m 8s docs in the patch passed.
+1 💚 asflicense 0m 14s The patch does not generate ASF License warnings.
61m 46s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-260/3/artifact/out/Dockerfile
GITHUB PR #260
JIRA Issue TEZ-4464
Optional Tests dupname asflicense javac javadoc unit xml compile markdownlint mvnsite
uname Linux 427d1328a191 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 34d6810
Default Java Private Build-1.8.0_352-8u352-ga-1~20.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08
markdownlint https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-260/3/artifact/out/diff-patch-markdownlint.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-260/3/testReport/
Max. process+thread count 72 (vs. ulimit of 5500)
modules C: docs U: docs
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-260/3/console
versions git=2.25.1 maven=3.6.3 markdownlint=0.23.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog abstractdog self-requested a review January 2, 2023 08:47
Copy link
Contributor

@abstractdog abstractdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

markdownlint issues are not introduced by this patch, LGTM +1

@abstractdog abstractdog merged commit 4fd2db3 into apache:master Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants