Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEZ-4397: Open Tez Input splits asynchronously #263

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

shameersss1
Copy link
Contributor

@shameersss1 shameersss1 commented Jan 31, 2023

Tez input splits can be opened asynchronously. This will reduce the amount of time spent for s3 to prepare the connection and opening the object.

The changes are taken from the original PR: #195 with some additional changes

  1. Disable the feature by default (to avoid regression in dependent engines)
  2. Minor refactoring

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

Copy link
Contributor

@abstractdog abstractdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very minor nits, otherwise it looks good
precommit is stable now, once this passes, I'm ready to merge

@tez-yetus

This comment was marked as outdated.

@tez-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 38s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 15m 29s master passed
+1 💚 compile 0m 32s master passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04
+1 💚 compile 0m 31s master passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08
+1 💚 checkstyle 1m 1s master passed
+1 💚 javadoc 0m 39s master passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04
+1 💚 javadoc 0m 28s master passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08
+0 🆗 spotbugs 1m 11s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 1m 8s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 18s the patch passed
+1 💚 compile 0m 18s the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04
+1 💚 javac 0m 18s the patch passed
+1 💚 compile 0m 17s the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08
+1 💚 javac 0m 17s the patch passed
+1 💚 checkstyle 0m 12s tez-mapreduce: The patch generated 0 new + 32 unchanged - 1 fixed = 32 total (was 33)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 15s the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04
+1 💚 javadoc 0m 14s the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08
+1 💚 findbugs 0m 41s the patch passed
_ Other Tests _
+1 💚 unit 1m 27s tez-mapreduce in the patch passed.
+1 💚 asflicense 0m 13s The patch does not generate ASF License warnings.
25m 21s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-263/6/artifact/out/Dockerfile
GITHUB PR #263
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux 2257340f0786 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / e236f51
Default Java Private Build-1.8.0_352-8u352-ga-1~22.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~22.04-b08
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-263/6/testReport/
Max. process+thread count 238 (vs. ulimit of 5500)
modules C: tez-mapreduce U: tez-mapreduce
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-263/6/console
versions git=2.34.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@abstractdog abstractdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abstractdog abstractdog merged commit e3e91a1 into apache:master Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants