Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEZ-4475: VertexStatus is missing in TestLocalMode if DAG finishes too early - causing NPE in unit test #267

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

abstractdog
Copy link
Contributor

No description provided.

@abstractdog abstractdog changed the title TEZ-4475: VertexStatus is missing in TestLocalMode if DAG finishes too quickly - causing NPE in unit test TEZ-4475: VertexStatus is missing in TestLocalMode if DAG finishes too early - causing NPE in unit test Feb 13, 2023
@tez-yetus

This comment was marked as outdated.

@tez-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 23m 28s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 💚 mvninstall 15m 37s master passed
+1 💚 compile 0m 32s master passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04
+1 💚 compile 0m 31s master passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08
+1 💚 checkstyle 1m 5s master passed
+1 💚 javadoc 0m 36s master passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04
+1 💚 javadoc 0m 26s master passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08
+0 🆗 spotbugs 1m 10s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 1m 7s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 18s the patch passed
+1 💚 compile 0m 19s the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04
+1 💚 javac 0m 19s the patch passed
+1 💚 compile 0m 17s the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08
+1 💚 javac 0m 17s the patch passed
-0 ⚠️ checkstyle 0m 11s tez-tests: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 13s the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04
+1 💚 javadoc 0m 12s the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08
+1 💚 findbugs 0m 37s the patch passed
_ Other Tests _
+1 💚 unit 39m 41s tez-tests in the patch passed.
+1 💚 asflicense 0m 16s The patch does not generate ASF License warnings.
86m 24s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-267/2/artifact/out/Dockerfile
GITHUB PR #267
JIRA Issue TEZ-4475
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux 8c6d3d8aaf08 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / e3e91a1
Default Java Private Build-1.8.0_352-8u352-ga-1~22.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~22.04-b08
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-267/2/artifact/out/diff-checkstyle-tez-tests.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-267/2/testReport/
Max. process+thread count 1331 (vs. ulimit of 5500)
modules C: tez-tests U: tez-tests
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-267/2/console
versions git=2.34.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@rbalamohan rbalamohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abstractdog abstractdog merged commit 97cc788 into apache:master Feb 14, 2023
@tez-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ patch 0m 4s #267 does not apply to master. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/TEZ/How+to+Contribute+to+Tez for help.
Subsystem Report/Notes
GITHUB PR #267
JIRA Issue TEZ-4475
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-267/3/console
versions git=2.17.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants