Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEZ-4487: Add class name profiling option in ProfileServlet #281

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

difin
Copy link
Contributor

@difin difin commented Apr 10, 2023

What changes were proposed in this pull request?
Adding support for method name profiling to Tez's ProfileServlet.

Why are the changes needed?
Tez has ProfileServlet. It makes use of async-profiler and allows profiling specific events. Currently profileServlet supports events like cpu, alloc, lock etc. It will be good to enhance to support method name profiling as well.

Does this PR introduce any user-facing change?
No

How was this patch tested?
Automated pre-commit tests;
Manual testing was done as part of HIVE-27184 and the same changes are proposed here.

@tez-yetus

This comment was marked as outdated.

@abstractdog abstractdog self-requested a review April 13, 2023 08:51
Copy link
Contributor

@abstractdog abstractdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor formatting issue, other than that LGTM

@tez-yetus

This comment was marked as outdated.

@difin
Copy link
Contributor Author

difin commented Apr 13, 2023

Hi @abstractdog , I fixed the line that had a whitespace, but it says there is one more line that ends with a whitespace. I checked all the lines that I changed and couldn't find additional whitespace.

@abstractdog abstractdog self-requested a review April 14, 2023 07:01
@abstractdog
Copy link
Contributor

abstractdog commented Apr 14, 2023

Hi @abstractdog , I fixed the line that had a whitespace, but it says there is one more line that ends with a whitespace. I checked all the lines that I changed and couldn't find additional whitespace.

@difin: there is indeed a whitespace in line 208, checked locally

+      response.getWriter().write("Event and method aren't allowed to be both used in the same request.");
+      return;
+    }
+    <-- here
     if (process == null || !process.isAlive()) {
       try {

@aturoczy
Copy link

Sharp eyes :)
https://www.youtube.com/watch?v=V7PLxL8jIl8

@difin
Copy link
Contributor Author

difin commented Apr 17, 2023

Hi @abstractdog,
Thanks, removed the trailing whitespace.
Can you please review again?

@tez-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 24m 57s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 15m 37s master passed
+1 💚 compile 0m 23s master passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu122.04
+1 💚 compile 0m 21s master passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~22.04-b09
+1 💚 checkstyle 0m 53s master passed
+1 💚 javadoc 0m 31s master passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu122.04
+1 💚 javadoc 0m 20s master passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~22.04-b09
+0 🆗 spotbugs 0m 57s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 0m 55s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 13s the patch passed
+1 💚 compile 0m 13s the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu122.04
+1 💚 javac 0m 13s the patch passed
+1 💚 compile 0m 12s the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~22.04-b09
+1 💚 javac 0m 12s the patch passed
+1 💚 checkstyle 0m 8s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 13s the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu122.04
+1 💚 javadoc 0m 11s the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~22.04-b09
+1 💚 findbugs 0m 35s the patch passed
_ Other Tests _
+1 💚 unit 0m 29s tez-common in the patch passed.
+1 💚 asflicense 0m 11s The patch does not generate ASF License warnings.
47m 15s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-281/3/artifact/out/Dockerfile
GITHUB PR #281
JIRA Issue TEZ-4487
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux b97efeff0012 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 9a729cd
Default Java Private Build-1.8.0_362-8u362-ga-0ubuntu1~22.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~22.04-b09
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-281/3/testReport/
Max. process+thread count 91 (vs. ulimit of 5500)
modules C: tez-common U: tez-common
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-281/3/console
versions git=2.34.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog abstractdog merged commit 2fe3c46 into apache:master Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants