-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEZ-4487: Add class name profiling option in ProfileServlet #281
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor formatting issue, other than that LGTM
tez-common/src/main/java/org/apache/tez/common/web/ProfileServlet.java
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
Hi @abstractdog , I fixed the line that had a whitespace, but it says there is one more line that ends with a whitespace. I checked all the lines that I changed and couldn't find additional whitespace. |
@difin: there is indeed a whitespace in line 208, checked locally
|
Sharp eyes :) |
Hi @abstractdog, |
💔 -1 overall
This message was automatically generated. |
What changes were proposed in this pull request?
Adding support for method name profiling to Tez's ProfileServlet.
Why are the changes needed?
Tez has ProfileServlet. It makes use of async-profiler and allows profiling specific events. Currently profileServlet supports events like cpu, alloc, lock etc. It will be good to enhance to support method name profiling as well.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Automated pre-commit tests;
Manual testing was done as part of HIVE-27184 and the same changes are proposed here.