THRIFT-2885: Add a 'fullcamel' option for obj-c #383
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddgardner
changed the title
|
This pull request is being closed due to lack of activity. |
jeking3
added a commit
to jeking3/thrift
that referenced
this pull request
Mar 10, 2018
This closes apache#93 This closes apache#326 This closes apache#345 This closes apache#352 This closes apache#353 This closes apache#383 This closes apache#395 This closes apache#413 This closes apache#488 This closes apache#555 This closes apache#624 This closes apache#731 This closes apache#747 This closes apache#756
Jens-G
pushed a commit
to Jens-G/thrift
that referenced
this pull request
Apr 14, 2019
Sentinel GET-MASTER-ADDR-BY-NAME throws exception when service name i…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to write your idl files in snake_case and have your objective c code be in the (stylistic) camelCase. It makes the java option of the same name.
It also fixes a minor warning about isEqual methods with no members (which caused an unused variable "other").
Tested by reading and compiling generated code for tutorial; didn't see any tests for compiler outputs.